videre-sdk: name the one-poll driver for the seam it asserts - #576
Merged
Conversation
This was referenced Jul 24, 2026
mfw78
added a commit
that referenced
this pull request
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Drop the
rtmodule in videre-sdk and move its one-poll future driver intoclient.rsbeside theVenueTransportseam, renamed fromcompletetopoll_oncereturningPoll<F::Output>. Rewrite the doc to cite the real warrant:videre:venue/client@0.1.0declares plain funcs, so a transport over the host import resolves on the first poll, andNone/Pendingmeans a foreign impl suspended, which the keeper macro folds to a fault. Update the emitted path invidere-macros/src/keeper.rsand every call site. Route thesweep.rssuspension arm throughRetrierfor parity with theClientError::Venuearm.Why
rtimplied a scheduler where there is only a single poll, was the sole abbreviated module name, and collided withwit_bindgen::rt.completeasserted completion while the signature returnedOption. The old doc over-claimed "guest host imports are synchronous", a warrant that does not hold for the whole runtime and prompted a rejected hoist into L1. After the M5 carve this becomes tag-pinned public API, so the naming must settle first.Testing
cargo fmt --all -- --check; cargo clippy --workspace --all-targets --all-features --locked -D warnings; wasm32-wasip2 release build of all 16 modules plus the cow adapter (17 wasms); cargo nextest run --workspace --all-features --no-fail-fast --locked (795 passed); cargo test --doc --workspace --all-features --locked; RUSTDOCFLAGS="-D warnings" cargo doc --workspace --no-deps --locked; check-venue-agnostic.sh; check-cow-orderbook-only.sh. All green.
AI Assistance
Implemented with Claude Code.
Closes #544